Re-open IndexedDB if closed #3535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 5596625 We got this. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
schmidt-sebastian
force-pushed
the
mrschmidt/indexeddbfailures
branch
from
2fec973 to
fa7a185
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/indexeddbfailures
branch
from
fa7a185 to
e8c09bb
Compare
schmidt-sebastian
changed the title
schmidt-sebastian
force-pushed
the
mrschmidt/indexeddbfailures
branch
from
ddd57b2 to
9a03405
Compare
|
|
||
| request.onblocked = () => { | ||
| reject( | ||
| new IndexedDbTransactionError( |
There was a problem hiding this comment.
This is mostly a copy of the code above, but this line changed from FirestoreError to IndexedDbTransactionError.
wilhuff
approved these changes
Aug 5, 2020
| db.close(); | ||
| await db.runTransaction('readwrite', V1_STORES, () => | ||
| PersistencePromise.resolve() | ||
| ); |
There was a problem hiding this comment.
This test doesn't make an assertion, which is usually a sign that something's missing. If this would implicitly fail somehow it's worth adding a comment about that or perhaps adding a does not throw expectation.
There was a problem hiding this comment.
I am not sure how expect().doesNotThrow() interacts with Promises, so I added a comment instead.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an IndexedDb error that may occur when a transaction is first opened. The error
The database connection is closingcan be reproduced locally by invoking SimpleDb.close() and then callingdb.transactionand this PR fixes at least this case by extending the IndexedDB retry code to include the code arounddb.transactionand by closing and re-opening the IndexedDB instance.Fixes #3495