Skip to content

add IS_NOT_NULL and IS_NOT_NAN protos #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2020
Merged

add IS_NOT_NULL and IS_NOT_NAN protos #3533

merged 1 commit into from
Aug 3, 2020

Conversation

thebrianchen
Copy link

Forgot to add these in #3528.

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2020

💥 No Changeset

Latest commit: 8822994

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thebrianchen thebrianchen requested a review from wilhuff July 31, 2020 21:19
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Jul 31, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (2bc2621) and head commit (ac33b49).

Test Logs

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Aug 3, 2020
@thebrianchen thebrianchen merged commit cf9dd92 into master Aug 3, 2020
@thebrianchen thebrianchen deleted the bc/ne-proto2 branch August 3, 2020 18:52
@firebase firebase locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants