Skip to content

Undo prettier for generated source #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jul 30, 2020

I accidentally pushed a commit that included prettier formatting for our generated scripts/*.js files in #3508. I didn't want to re-run the CI so here is a clean up PR. The idea of not using prettier for these files to indicate that these are not meant for review.

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2020

💥 No Changeset

Latest commit: 2a6257a

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (8a8e60a) and head commit (c8c6dcd).

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit 458f8b7 into master Jul 31, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/unpretty branch August 10, 2020 19:14
@firebase firebase locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants