-
Notifications
You must be signed in to change notification settings - Fork 928
LocalStore-only queries #3508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
LocalStore-only queries #3508
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
829de71
Simplify Listen API
schmidt-sebastian cab645d
Tree-shakeable FirestoreClient
schmidt-sebastian 69e746c
Remove duplication
schmidt-sebastian 7ab31f9
Merge
schmidt-sebastian 04e4127
Merge branch 'master' into mrschmidt/treeshakeablefc
schmidt-sebastian e8ed680
Address regression
schmidt-sebastian 026fa9a
Fix bug
schmidt-sebastian 313478c
Cleanup
schmidt-sebastian 9890082
Next bug fix
schmidt-sebastian cde5600
Refactor some FirestoreClient methods
schmidt-sebastian f650ee0
LocalStore-only queries
schmidt-sebastian 1f31fdf
Don't run prettier on generated files
schmidt-sebastian 9b63c17
Lint
schmidt-sebastian 63fc9d2
Comments
schmidt-sebastian d5e60ca
Merge
schmidt-sebastian ab4dfb9
Remove assert
schmidt-sebastian e519317
Lint
schmidt-sebastian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: nothing is logged if the promise was not found -- is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that is ok. We only log when components are initialized and when they are terminated.