Make loadBundle work with exp build #3488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 No ChangesetLatest commit: 8baf8fc Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
wu-hui
force-pushed
the
wuandy/ExpBundlesApi
branch
from
4c037e0 to
23ea4d8
Compare
Binary Size ReportAffected SDKs
Test Logs |
schmidt-sebastian
approved these changes
Jul 27, 2020
packages/firestore/exp/test/shim.ts
Outdated
| @@ -168,7 +169,7 @@ export class FirebaseFirestore implements legacy.FirebaseFirestore { | |||
|
|
|||
| loadBundle( | |||
| bundleData: ArrayBuffer | ReadableStream<Uint8Array> | string | |||
| ): legacy.LoadBundleTask { | |||
| ): LoadBundleTask { | |||
There was a problem hiding this comment.
This should return the legacy Task (all APIs return the legacy type), even though it is for now the same.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note in
exp/src/api/database.tsandshim.tsthe diff is based on some hacks I pushed towuandy/Bundles.