Remove duplicate test run #3459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests with persistence run all tests twice already - once with and once without persistence. Thus, we can skip the setting test run.
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
💥 No ChangesetLatest commit: fbd66d4 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Feiyang1
reviewed
Jul 23, 2020
| @@ -49,7 +49,6 @@ async function run(): Promise<void> { | |||
| await emulator.download(); | |||
| await emulator.setUp(); | |||
| await runTest(emulator.port, emulator.projectId, true); | |||
There was a problem hiding this comment.
Can you copy the PR comment here?
Feiyang1
approved these changes
Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests with persistence run all tests twice already - once with and once without persistence. Thus, we can skip the setting test run.