Skip to content

Use the SDK version from Firebase package.json #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Use the SDK version from Firebase package.json #3443

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d93d75
Use the SDK version from Firebase package.json
schmidt-sebastian Jul 20, 2020
9d2ab11
Remove const from ES5 build
schmidt-sebastian Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/firestore/src/core/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,5 @@
* limitations under the License.
*/

import firebase from '@firebase/app';

/** The semver (www.semver.org) version of the SDK. */
export const SDK_VERSION = firebase.SDK_VERSION;
export { version as SDK_VERSION } from '../../../firebase/package.json';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to use 'rollup-plugin-json' to resolve it in all build tasks.
You will want to set preferConst: true for es2017 builds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am already using it in exp and lite, and we have been using it in the legacy build already. Is there some other target that is missing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. I did see it in rollup.config.es5.js, but now I realize es5 builds are based on esm2017 builds which uses it.