Remove MultiTabLocalStore #3436
Conversation
💥 No ChangesetLatest commit: 08f927a Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
schmidt-sebastian
force-pushed
the
mrschmidt/onelocalstore
branch
from
41ea951 to
a857f59
Compare
| @@ -202,7 +202,8 @@ export class FirestoreClient { | |||
| enableNetwork(): Promise<void> { | |||
| this.verifyNotTerminated(); | |||
| return this.asyncQueue.enqueue(() => { | |||
| return this.syncEngine.enableNetwork(); | |||
There was a problem hiding this comment.
I removed the FirestoreClient -> SyncEngine -> LocalStore -> Persistence indirection for enableNetwork and disableNetwork since I didn't want to come up with non-conflicting global names for the new free-standing functions.
Binary Size ReportAffected SDKs
Test Logs |
| const mutationQueueImpl = debugCast( | ||
| localStoreImpl.mutationQueue, | ||
| IndexedDbMutationQueue // We only support IndexedDb in multi-tab mode. | ||
| ); |
There was a problem hiding this comment.
This setup is being done in every reworked method, would it be possible to refactor it out into a helper function returning two values?
There was a problem hiding this comment.
It's not that pretty since it needs a cast in the method call, but I changed it:
const [localStoreImpl, mutationQueueImpl] =
debugCast(localStore, LocalStoreImpl, (localStoreImpl as LocalStoreImpl).mutationQueue, IndexedDbMutationQueue);
There was a problem hiding this comment.
Hm, I undid this since this pattern actually uses one more line for each invocation.
There was a problem hiding this comment.
Hmm, what I had in mind was just
const [localStoreImpl, mutationQueueImpl] = foo(localStore);with the helper function taking care of everything else.
There was a problem hiding this comment.
I can add a multiTabLocalStore function that returns LocalStoreImpl, IndexedDbRemoteDocumentCache, IndexedDbMutationQueue and IndexedDbTargetCache. Does that sound good to you?
| * Returns the set of documents that have been updated since the last call. | ||
| * If this is the first call, returns the set of changes since client | ||
| * initialization. Further invocations will return document changes since | ||
| * the point of rejection. |
There was a problem hiding this comment.
Can you clarify what is meant by rejection?
There was a problem hiding this comment.
Changed to will return document that have changed since the prior call.
| async synchronizeLastDocumentChangeReadTime(): Promise<void> { | ||
| this.lastDocumentChangeReadTime = await this.persistence.runTransaction( | ||
| /** | ||
| * Reads the newest document change from persistence and forwards the internal |
There was a problem hiding this comment.
Nit: can you clarify where/to what it's being forwarded?
There was a problem hiding this comment.
The "forward" does not mean "send something along" but rather "move forward". Rewritten.
This PR is part of my effort to create a cache-only entry point into Firestore (for
getDocFromLocalCache()). My plan is to split up the component providers and extract one that only providesPersistence,SharedClientStateandLocalStore. The "WIP end result" is here: #3425. This PR is a version of the first commit in that PR.To avoid the combinatorial explosion of
ComponentProviders, this PR removesMultiTabLocalStoreand instead makes all methods inMultiTabLocalStoretree-shakeable.