Add Storage Integration tests #3414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 088b404 We got this. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…js-sdk into mrschmidt/storagetest
| @@ -54,7 +54,11 @@ export class FirebaseStorageError implements Error { | |||
| } | |||
|
|
|||
| get message(): string { | |||
| return this.message_; | |||
| if (this.serverResponse_) { | |||
| return this.message_ + '\n' + this.serverResponse_; | |||
There was a problem hiding this comment.
Added this so that the server response shows up in the error message for "unknown" errors.
Binary Size ReportAffected SDKs
Test Logs |
hsubox76
approved these changes
Jul 16, 2020
| @@ -16,6 +16,7 @@ | |||
| */ | |||
|
|
|||
| import { base64 } from '@firebase/util'; | |||
| import { uint8ArrayFromBinaryString } from '../../util/byte_string'; | |||
There was a problem hiding this comment.
I see Github Actions has inlined this ts error from the build log ('uint8ArrayFromBinaryString' is defined but never used) so that's cool.
There was a problem hiding this comment.
Removed this line.
…js-sdk into mrschmidt/storagetest
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a barebones integration test file for Storage. Requires anonymous auth in the test project.