-
Notifications
You must be signed in to change notification settings - Fork 938
Bundle's named query resume. #3395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 48 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
9602712
Renaming interfaces without leading I
wu-hui c5e783e
Initial commit of bundle reading - for web only.
wu-hui 5e7fb89
Tests only run when it is not Node.
wu-hui 1ee1615
Fix redundant imports
wu-hui 18f0be1
Fix missing textencoder
wu-hui aa455bf
Remove generator.
wu-hui 78248cd
Support bundle reader for Node
wu-hui 83160a1
Fix rebase errors.
wu-hui 24e10cb
Remote 'only'
wu-hui 9d6edc5
Merge branch 'wuandy/Bundles' into wuandy/BundleReaderNode
wu-hui 4cbe608
Merge branch 'wuandy/Bundles' into wuandy/BundleReaderNode
wu-hui 4313e51
Added more comments, and more tests for Node.
wu-hui 296cfc4
Implement BundleCache.
wu-hui fff3d36
Add applyBundleDocuments to local store.
wu-hui fb762de
Add rest of bundle service to localstore
wu-hui 1ec4182
Simplify change buffer get read time logic.
wu-hui cd3ab7a
Fix lint errors
wu-hui d991c75
Add comments.
wu-hui af097c5
Change localstore to check for newer bundle directly.
wu-hui e735e23
temp checkin
wu-hui 17ba434
Implement without async/await
wu-hui f808d8d
Major code complete.
wu-hui db1d864
Integration tests added.
wu-hui 979ffd9
Added spec tests.
wu-hui f7ff495
Add comments and move types to d.ts
wu-hui 556a007
Support loading string for real.
wu-hui adf1504
Makes sure SDK still works after loading bad bundles.
wu-hui b364ab0
Better spect test.
wu-hui 2588f20
Load bundles from secondary clients should raise snapshots
wu-hui 93bc964
Support secondary to secondary.
wu-hui cb56334
Implementation.
wu-hui cd88414
Implements bundled query loading and resuming.
wu-hui 99610d7
Merge branch 'wuandy/Bundles' into wuandy/BundlesLoadFromSecondary
wu-hui a6963dc
Merge branch 'wuandy/BundlesLoadFromSecondary' into wuandy/BundleQuer…
wu-hui d738d9d
Undo rename
wu-hui 9b00a85
Merge branch 'wuandy/Bundles' into wuandy/BundleQueryResume
wu-hui 23ea4d8
Make loadBundle work with exp build
wu-hui 27e0fd8
Add TODO
wu-hui 8147aea
Merge branch 'wuandy/ExpBundlesApi' into wuandy/BundleQueryResume
wu-hui a3d0bb0
Undo some merges
wu-hui 48658b4
Merge branch 'wuandy/BundleQueryResume' of github.com:firebase/fireba…
wu-hui 8baf8fc
Use legacy.LoadBundleTask
wu-hui 7abcf19
Merge branch 'wuandy/ExpBundlesApi' into wuandy/BundleQueryResume
wu-hui f228dfb
Address first round feedbacks
wu-hui 5a6e8ea
Merge branch 'wuandy/Bundles' into wuandy/BundleQueryResume
wu-hui 70d350a
Save readtime to target cache and remove readtime from Query
wu-hui 8ea9e7b
Save named queries to target cache as well.
wu-hui 487982c
Fix more errors.
wu-hui 9f1e135
Address feedback
wu-hui 5eb05d9
Remove readTime from allocateTarget
wu-hui e057fc1
drop resume token when updating read time.
wu-hui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs merging again. The call to
getNamedQuery
should call a free-standing version that takes LocalStore as an argument. All methods in FirestoreClient have been updated.Let me know if you need help with this. You can also defer to a follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd like to defer to my a follow up PR.