Migrate testing to rules-unit-testing

[samtstern]

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

Googlers: see change rationale here

TODO:

• Un-delete the testing package (see Restore testing package #3556)
• We need Use Admin AuthTokenProvider when targeting Emulator #3228 to be submitted and released, otherwise we can't use firebase-admin to create mock admin apps without setting GOOGLE_APPLICATION_CREDENTIALS.
• Wait for resolution of [Firestore] firestore.settings() cannot have 'host' when FIRESTORE_EMULATOR_HOST is set googleapis/nodejs-firestore#1265 which is causing test failures
• Figure out a meaningful test for initializeAdminApp()
• Add change set

Testing

• Added unit tests
• Tested locally with quickstart-testing although it was made difficult by the fact that file: deps with peerDependencies don't play nice.

API Changes

• Rename @firebase/testing to @firebase/rules-unit-testing

[changeset-bot]

🦋 Changeset is good to go

Latest commit: 3b0c125

We got this.

This PR includes changesets to release 1 package

Name	Type
@firebase/rules-unit-testing	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[samtstern]

We now make sure the error is a FirebaseError with a message that contains PERMISSION_DENIED. This prevents connect failures from giving the illusion of security.

[google-oss-bot]

Binary Size Report

Affected SDKs

• @firebase/rules-unit-testing

  Type	Base (2245ad7)	Head (47d8e70)	Diff
  main	?	7.24 kB	? (?)

Test Logs

• Base (2245ad73): https://github.com/firebase/firebase-js-sdk/actions/runs/206043080
• Head (47d8e700): https://github.com/firebase/firebase-js-sdk/actions/runs/206070301

[yuchenshi]

One question: How would you update the old package once this PR gets merged? For example, if we'd like to add a deprecation notice or have the methods print out a warning, how would we track and review those changes?

[samtstern]

@yuchenshi I believe that deprecation message is entirely managed by running npm deprecate on @firebase/testing ... it's not something we do here on GitHub (correct me if I am wrong @Feiyang1)

[yuchenshi]

@yuchenshi I believe that deprecation message is entirely managed by running npm deprecate on @firebase/testing ... it's not something we do here on GitHub (correct me if I am wrong @Feiyang1)

What if we want to print a warning message when developers call the initializeAdminApp() method to notify them of the caveats and the upcoming change?

Also, although unlikely, what if we need to apply security patches? e.g. updating a dependency due to an open vulnerability report?

[samtstern]

@yuchenshi I would be fine to do a copy instead of a fork, I just want to know if @Feiyang1 has any problem with "dead" code sitting around in packages/testing

[samtstern]

@Feiyang1 can you weigh in on the copy vs fork thing? Would it be alright if we had @firebase/testing and @firebase/rules-unit-testing side by side for at least one release?

[Feiyang1]

I'm fine with that. We can remove @firebase/testing in the repo when we feel comfortable.

[samtstern]

@Feiyang1 after you approve this and #3556 I wil merge it into here and then merge this when the tests pass.