Skip to content

Upgrade to latest version of closure #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 28, 2020
Merged

Upgrade to latest version of closure #3372

merged 6 commits into from
Jul 28, 2020

Conversation

rafikhan
Copy link
Contributor

@rafikhan rafikhan commented Jul 8, 2020

This PR upgrades to the latest version of closure (20200628.0.0)

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2020 •
edited
Loading

🦋 Changeset is good to go

Latest commit: 433c8ba

We got this.

This PR includes changesets to release 9 packages
Name Type
@firebase/webchannel-wrapper Minor
@firebase/firestore Patch
firebase Patch
@firebase/testing Patch
firebase-browserify-test Patch
firebase-package-typings-test Patch
firebase-messaging-selenium-test Patch
firebase-typescript-test Patch
firebase-webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 8, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (b07f822) Head (3eabe9f) Diff
    esm2017 8.68 kB 9.66 kB +975 B (+11.2%)
    main 9.69 kB 10.9 kB +1.20 kB (+12.3%)
    module 9.37 kB 10.6 kB +1.22 kB (+13.0%)

  • @firebase/auth

    Type Base (b07f822) Head (3eabe9f) Diff
    browser ? 177 kB ? (?)

  • @firebase/database

    Type Base (b07f822) Head (3eabe9f) Diff
    browser 268 kB 269 kB +848 B (+0.3%)
    esm2017 235 kB 236 kB +523 B (+0.2%)
    main 269 kB 270 kB +848 B (+0.3%)
    module 267 kB 268 kB +843 B (+0.3%)

  • @firebase/firestore

    Type Base (b07f822) Head (3eabe9f) Diff
    browser 247 kB 246 kB -1.10 kB (-0.4%)
    esm2017 194 kB 193 kB -470 B (-0.2%)
    main 495 kB 471 kB -24.1 kB (-4.9%)
    module 245 kB 244 kB -1.12 kB (-0.5%)
    react-native 194 kB 193 kB -459 B (-0.2%)

  • @firebase/firestore/exp

    Type Base (b07f822) Head (3eabe9f) Diff
    browser ? 187 kB ? (?)
    main 400 kB 513 kB +113 kB (+28.3%)
    module ? 187 kB ? (?)
    react-native ? 187 kB ? (?)

  • @firebase/firestore/lite

    Type Base (b07f822) Head (3eabe9f) Diff
    browser ? 67.9 kB ? (?)
    main 124 kB 499 kB +374 kB (+301.6%)
    module ? 67.9 kB ? (?)
    react-native ? 68.0 kB ? (?)

  • @firebase/firestore/memory

    Type Base (b07f822) Head (3eabe9f) Diff
    browser 185 kB 185 kB -8 B (-0.0%)
    esm2017 145 kB 145 kB -9 B (-0.0%)
    main 364 kB 346 kB -18.0 kB (-5.0%)
    module 183 kB 183 kB -54 B (-0.0%)
    react-native 145 kB 145 kB +5 B (+0.0%)

  • @firebase/performance

    Type Base (b07f822) Head (3eabe9f) Diff
    browser 26.7 kB 26.7 kB +1 B (+0.0%)
    esm2017 24.7 kB 24.7 kB +1 B (+0.0%)
    main 26.7 kB 26.7 kB +1 B (+0.0%)
    module 26.4 kB 26.4 kB +1 B (+0.0%)

  • @firebase/storage

    Type Base (b07f822) Head (3eabe9f) Diff
    esm2017 56.4 kB 54.9 kB -1.42 kB (-2.5%)
    main 62.7 kB 61.3 kB -1.38 kB (-2.2%)
    module 62.5 kB 61.1 kB -1.39 kB (-2.2%)

  • @firebase/util

    Type Base (b07f822) Head (3eabe9f) Diff
    browser 19.6 kB 20.5 kB +921 B (+4.7%)
    esm2017 17.5 kB 18.3 kB +786 B (+4.5%)
    main 19.6 kB 20.5 kB +921 B (+4.7%)
    module 18.7 kB 19.5 kB +832 B (+4.5%)

  • @firebase/webchannel-wrapper

    Type Base (b07f822) Head (3eabe9f) Diff
    esm2017 37.7 kB 39.4 kB +1.69 kB (+4.5%)
    main 38.8 kB 41.0 kB +2.21 kB (+5.7%)
    module 38.4 kB 40.6 kB +2.21 kB (+5.8%)

  • firebase

    Click to show 14 binary size changes.
    Type Base (b07f822) Head (3eabe9f) Diff
    firebase-analytics.js 26.6 kB 28.0 kB +1.36 kB (+5.1%)
    firebase-auth.js 174 kB 173 kB -228 B (-0.1%)
    firebase-database.js 187 kB 187 kB -531 B (-0.3%)
    firebase-firestore.js 285 kB 285 kB -384 B (-0.1%)
    firebase-firestore.memory.js 224 kB 225 kB +1.04 kB (+0.5%)
    firebase-functions.js 9.84 kB 9.84 kB -1 B (-0.0%)
    firebase-installations.js 19.2 kB 19.2 kB -4 B (-0.0%)
    firebase-messaging.js 39.2 kB 39.2 kB -2 B (-0.0%)
    firebase-performance-standalone.es2017.js 72.0 kB 72.0 kB -10 B (-0.0%)
    firebase-performance-standalone.js 47.4 kB 47.2 kB -189 B (-0.4%)
    firebase-performance.js 37.8 kB 37.6 kB -203 B (-0.5%)
    firebase-remote-config.js 37.0 kB 37.0 kB -4 B (-0.0%)
    firebase-storage.js 40.9 kB 39.8 kB -1.02 kB (-2.5%)
    firebase.js 819 kB 818 kB -919 B (-0.1%)

Test Logs

schmidt-sebastian
schmidt-sebastian approved these changes Jul 8, 2020
View reviewed changes
.changeset/calm-apes-collect.md
@@ -0,0 +1,7 @@
---
'@firebase/webchannel-wrapper': minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Feiyang1 Do we also need to explicitly add '@firebase/firestore' and 'firebase'? i assume this is needed to make sure they get released, but wanted to double check.

Copy link
Member

@Feiyang1 Feiyang1 Jul 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It will trigger a patch release for @firebase/firestore and firebase automatically which I guess is what you want.

Copy link
Member

@Feiyang1 Feiyang1 Jul 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it a minor release? looks like a patch release to me. @rafikhan

Copy link
Member

@Feiyang1 Feiyang1 Jul 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there is 5% increase in the library size. We didn't upgrade closure to the latest yet exactly because of it. @hsubox76 investigated it and found it's because the usage of Set is no longer stripped in the closure library - google/closure-library#1070. However the closure team didn't fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We settled on a "minor" release to mitigate some of the risks associated with jumping between major versions in google-closure-library. Have we previously just released patch releases for these updates?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have done patch releases for these updates in the past. As long as the Firestore node tests pass, we should be confident that it works, right?

In case you actually want to bump minor for @firebase/firestore and thus firebase, you should include them explicitly in the changeset.

@rafikhan rafikhan closed this Jul 15, 2020
@rafikhan rafikhan deleted the khanrafi/webchannelupgrade branch July 15, 2020 17:43
@rafikhan rafikhan restored the khanrafi/webchannelupgrade branch July 27, 2020 20:58
@rafikhan rafikhan reopened this Jul 27, 2020
@rafikhan rafikhan merged commit 7f0860a into master Jul 28, 2020
@google-oss-bot google-oss-bot mentioned this pull request Jul 28, 2020
Merged
schmidt-sebastian added a commit that referenced this pull request Jul 30, 2020
@schmidt-sebastian
Revert "Upgrade to latest version of closure (#3372)"
508bf71 
This reverts commit 7f0860a.
schmidt-sebastian added a commit that referenced this pull request Jul 30, 2020
@schmidt-sebastian
Revert "Upgrade to latest version of closure (#3372)"
0802ea7 
This reverts commit 7f0860a.
schmidt-sebastian added a commit that referenced this pull request Jul 30, 2020
@schmidt-sebastian
Revert "Upgrade to latest version of closure (#3372)"
9c320cd 
This reverts commit 7f0860a.
@firebase firebase locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@rafikhan rafikhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rafikhan @google-oss-bot @hiranya911 @Feiyang1 @hsubox76 @schmidt-sebastian