Skip to content

Misc fixes for firestore-exp API definition #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jul 6, 2020

Fixes some random issues in the index.d.ts file for the unreleased tree-shakeable clients. I also went back to the prior defintion of SetOptions, since it "just works" (tm) and allows me to write less validation code (no need to port the check that
"merge" and "mergeField" cannot be combined). Let me know if there are any concerns.

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2020

🦋 Changeset is good to go

Latest commit: ef4c6e1

We got this.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@schmidt-sebastian schmidt-sebastian changed the title Misc fixes for firestore-exp API Misc fixes for firestore-exp API definition Jul 6, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/messaging

    Type Base (ee1892d) Head (af2c06a) Diff
    esm2017 23.2 kB 23.2 kB +35 B (+0.2%)
    main 31.4 kB 31.4 kB +35 B (+0.1%)
    module 30.9 kB 30.9 kB +35 B (+0.1%)
  • firebase

    Type Base (ee1892d) Head (af2c06a) Diff
    firebase-messaging.js 39.1 kB 39.2 kB +43 B (+0.1%)
    firebase.js 819 kB 819 kB +43 B (+0.0%)

Test Logs

Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian schmidt-sebastian merged commit 26767cd into master Jul 7, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/indexdts branch July 9, 2020 17:44
@firebase firebase locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants