Add remaining firestore-exp functionality #3321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: d227cca We got this. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
force-pushed
the
mrschmidt/waitforpendingwrites
branch
from
511b5b2 to
ea2094e
Compare
Binary Size ReportAffected SDKsTest Logs |
dconeybe
approved these changes
Jun 30, 2020
| if (this._firestoreClientPromise !== undefined && !this._terminated) { | ||
| throw new FirestoreError( | ||
| Code.FAILED_PRECONDITION, | ||
| 'Persistence cannot be cleared after this Firestore instance is initialized.' |
There was a problem hiding this comment.
nit: This statement is not entirely correct. Consider this rewording:
Persistence can only be cleared before the Firestore instance is initialized or after it is terminated.
schmidt-sebastian
changed the base branch from
mrschmidt/onsnapshotsinsync
to
master
schmidt-sebastian
requested review from
alikn,
andirayo,
avolkovi,
egilmorez,
erikeldridge,
sam-gc,
scottcrossen,
yuchenshi,
zijianjoy and
zwu52
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some barebones support for the remaining API surface for the firestore-exp client. This is meant to unblock adding the Dependencies tests as well as the integration tests. TODOs added for functionality that is missing.