Skip to content

Fix firestore_bundle_proto rollup issue. #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jun 29, 2020

No description provided.

@wu-hui wu-hui requested a review from schmidt-sebastian June 29, 2020 17:49
@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2020

🦋 Changeset is good to go

Latest commit: 9d8490f

We got this.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wu-hui wu-hui changed the base branch from master to wuandy/Bundles June 29, 2020 17:49
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 29, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (af0c430) Head (ce9e18d) Diff
    browser 248 kB 250 kB +2.40 kB (+1.0%)
    esm2017 193 kB 195 kB +2.09 kB (+1.1%)
    main 493 kB 498 kB +5.26 kB (+1.1%)
    module 246 kB 248 kB +2.38 kB (+1.0%)
  • @firebase/firestore/exp

    Type Base (af0c430) Head (ce9e18d) Diff
    main 272 kB 277 kB +5.20 kB (+1.9%)
  • @firebase/firestore/memory

    Type Base (af0c430) Head (ce9e18d) Diff
    browser 186 kB 188 kB +2.74 kB (+1.5%)
    esm2017 145 kB 147 kB +2.60 kB (+1.8%)
    main 362 kB 368 kB +5.56 kB (+1.5%)
    module 184 kB 187 kB +2.75 kB (+1.5%)
  • firebase

    Type Base (af0c430) Head (ce9e18d) Diff
    firebase-firestore.js 286 kB 289 kB +2.28 kB (+0.8%)
    firebase-firestore.memory.js 225 kB 228 kB +2.67 kB (+1.2%)
    firebase.js 819 kB 822 kB +2.28 kB (+0.3%)

Test Logs

@wu-hui wu-hui merged commit 3a78d7c into wuandy/Bundles Jun 29, 2020
@firebase firebase locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants