Skip to content

update codeowner to allow approving changeset changes #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2020

🦋 Changeset is good to go

Latest commit: 7d8db66

We got this.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 26, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (8e0c036) Head (7a06141) Diff
    browser 248 kB 249 kB +334 B (+0.1%)
    esm2017 194 kB 194 kB +315 B (+0.2%)
    main 494 kB 494 kB +759 B (+0.2%)
    module 246 kB 246 kB +334 B (+0.1%)
  • @firebase/firestore/exp

    Type Base (8e0c036) Head (7a06141) Diff
    main 37.4 kB 271 kB +234 kB (+625.9%)
  • @firebase/firestore/lite

    Type Base (8e0c036) Head (7a06141) Diff
    main 140 kB 141 kB +448 B (+0.3%)
  • @firebase/firestore/memory

    Type Base (8e0c036) Head (7a06141) Diff
    browser 186 kB 186 kB +334 B (+0.2%)
    esm2017 145 kB 145 kB +315 B (+0.2%)
    main 363 kB 364 kB +759 B (+0.2%)
    module 184 kB 185 kB +334 B (+0.2%)
  • firebase

    Type Base (8e0c036) Head (7a06141) Diff
    firebase-firestore.js 287 kB 287 kB +324 B (+0.1%)
    firebase-firestore.memory.js 226 kB 226 kB +324 B (+0.1%)
    firebase.js 820 kB 820 kB +324 B (+0.0%)

Test Logs

@Feiyang1 Feiyang1 merged commit a4ff036 into master Jun 26, 2020
@Feiyang1 Feiyang1 deleted the fei-codeowner branch June 26, 2020 21:58
schmidt-sebastian pushed a commit that referenced this pull request Jun 30, 2020
* update codeowner to allow approving changeset changes

* Create kind-melons-obey.md

* Update CODEOWNERS
@firebase firebase locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants