Skip to content

Add writeBatch(), WriteBatch #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2020

🦋 Changeset is good to go

Latest commit: 85cd5bf

We got this.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -115,6 +117,69 @@ genericMutationTests({
delete: deleteDoc
});

describe('WriteBatch', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are copied for now.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 26, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore/exp

    Type Base (5f51ab5) Head (df998ca) Diff
    main 272 kB 274 kB +1.93 kB (+0.7%)
  • @firebase/firestore/lite

    Type Base (5f51ab5) Head (df998ca) Diff
    main 140 kB 141 kB +118 B (+0.1%)

Test Logs

Base automatically changed from mrschmidt/setdoc-exp to master June 27, 2020 05:13
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/writebatch-exp branch from 5e56ce7 to 2b9e653 Compare June 27, 2020 05:16
Copy link
Contributor

@rafikhan rafikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian schmidt-sebastian merged commit 32d91c0 into master Jun 29, 2020
schmidt-sebastian added a commit that referenced this pull request Jun 30, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/writebatch-exp branch July 9, 2020 17:44
@firebase firebase locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants