Make SyncEngine an interface. #3283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: e035d7c We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
wu-hui
force-pushed
the
wuandy/MakeSyncEngineInterface
branch
from
ce908d8 to
618e60a
Compare
schmidt-sebastian
approved these changes
Jun 25, 2020
| /** | ||
| * An impplementation of SyncEngine that implement SharedClientStateSyncer for | ||
| * An extension of SyncEngine that also include SharedClientStateSyncer for |
There was a problem hiding this comment.
s/include/includes
| */ | ||
| registerPendingWritesCallback(callback: Deferred<void>): Promise<void>; | ||
|
|
||
| activeLimboDocumentResolutions(): SortedMap<DocumentKey, TargetId>; |
There was a problem hiding this comment.
Add // Visible for testing
|
|
||
| activeLimboDocumentResolutions(): SortedMap<DocumentKey, TargetId>; | ||
|
|
||
| enqueuedLimboDocumentResolutions(): DocumentKey[]; |
There was a problem hiding this comment.
Add // Visible for testing
This reverts commit de8ed28.
Feiyang1
approved these changes
Jun 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.