Expose static members of public types in ESM2017 build #3259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs |
Feiyang1
suggested changes
Jun 23, 2020
packages/firestore/src/util/api.ts
Outdated
Comment on lines
48
to
56
| // Copy any static methods/members | ||
| // Copy instance methods/members | ||
| Object.assign(PublicConstructor, cls); |
There was a problem hiding this comment.
We don't need it anymore since instance methods/members are copied in prototype.
Feiyang1
approved these changes
Jun 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeConstructorPrivatecurrently does not re-assign static members in the ESM2017 build, which essentially breaks the static methods on Blob, FieldValue and FieldPath.