Tree-shakeable Bound #3250
Merged
Tree-shakeable Bound #3250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs |
dconeybe
approved these changes
Jun 22, 2020
packages/firestore/src/core/query.ts
Outdated
| return false; | ||
| } | ||
| for (let i = 0; i < left.position.length; i++) { | ||
| const thisPosition = left.position[i]; |
There was a problem hiding this comment.
nit: Consider renaming thisPosition to leftPosition and otherPosition to rightPosition.
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
schmidt-sebastian
changed the base branch from
mrschmdit/treeshakeabletarget
to
master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny follow up to #3248