Skip to content

Tree-Shakeable LocalSerializer #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2020
Merged

Tree-Shakeable LocalSerializer #3241

merged 3 commits into from
Jun 23, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jun 19, 2020 •
edited
Loading

This is a pretty low risk/low reward change (kind of disappointing). I wonder if we should take this to allow us to make parsing and writing bundles optional?

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 19, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (58e1b6f) Head (985358e) Diff
    browser 249 kB 248 kB -375 B (-0.2%)
    esm2017 194 kB 194 kB -118 B (-0.1%)
    main 492 kB 492 kB -392 B (-0.1%)
    module 246 kB 246 kB -375 B (-0.2%)

  • firebase

    Type Base (58e1b6f) Head (985358e) Diff
    firebase-firestore.js 287 kB 287 kB -370 B (-0.1%)
    firebase.js 820 kB 820 kB -370 B (-0.0%)

Test Logs

@schmidt-sebastian schmidt-sebastian requested a review from wu-hui June 19, 2020 21:49
@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Jun 23, 2020
@schmidt-sebastian schmidt-sebastian merged commit 2c8c17c into master Jun 23, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/localserializer branch July 9, 2020 17:45
@firebase firebase locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui