Skip to content

Add base64 externs for ReactNative build #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Add base64 externs for ReactNative build #3240

merged 2 commits into from
Jun 19, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Fixes #2667

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 19, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (35bc0a2) Head (4f0ab11) Diff
    react-native 195 kB 195 kB +20 B (+0.0%)
  • @firebase/firestore/memory

    Type Base (35bc0a2) Head (4f0ab11) Diff
    react-native 149 kB 149 kB +20 B (+0.0%)

Test Logs

@Feiyang1 Feiyang1 merged commit 246ed9d into master Jun 19, 2020
@Feiyang1 Feiyang1 deleted the mrschmidt/rndeps branch June 19, 2020 16:19
@djoiiwalraven
Copy link

djoiiwalraven commented Jun 19, 2020

I just updated firebase-js-sdk, but still getting issue: #2667.

Or will it take sometime before I can update to this version?

Warning I'm getting:
_[Unhandled promise rejection: TypeError: _util.base64.tI is not a function. (In '_util.base64.tI(t, !1)', '_util.base64.tI' is undefined)]

  • node_modules/@firebase/firestore/dist/index.rn.esm2017.js:3487:7 in ae#constructor
  • node_modules/@firebase/firestore/dist/index.rn.esm2017.js:10097:8 in Zi#xc
  • node_modules/@firebase/firestore/dist/index.rn.esm2017.js:9944:13 in Yi#constructor
  • node_modules/promise/setimmediate/core.js:37:14 in tryCallOne
  • node_modules/promise/setimmediate/core.js:123:25 in setImmediate$argument_0
  • node_modules/react-native/Libraries/Core/Timers/JSTimers.js:146:14 in _callTimer
  • node_modules/react-native/Libraries/Core/Timers/JSTimers.js:194:17 in _callImmediatesPass
  • node_modules/react-native/Libraries/Core/Timers/JSTimers.js:458:30 in callImmediates
  • [native code]:null in callImmediates
  • node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:407:6 in __callImmediates
  • node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:143:6 in __guard$argument_0
  • node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:384:10 in __guard
  • node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:142:17 in __guard$argument_0
  • [native code]:null in flushedQueue
  • [native code]:null in callFunctionReturnFlushedQueue_

@schmidt-sebastian
Copy link
Contributor Author

Sorry - this will be fixed in 7.15.3. We will update you when it has been released.

@schmidt-sebastian
Copy link
Contributor Author

@Feiyang1 published a new release.

@firebase firebase locked and limited conversation to collaborators Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7.9.1 prevent the use of firestore in React Native
4 participants