b/68251551: Send headers via URL Param to avoid CORS preflight round-trip. #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
requested review from
schmidt-sebastian and
wilhuff
as code owners
wenbozhu
reviewed
Nov 16, 2017
There was a problem hiding this comment.
FYI
$httpHeaders is formally defined here
https://github.com/google/closure-library/blob/master/closure/goog/net/rpc/httpcors.js#L40
|
Thanks @wenbozhu I added that in a comment (it's not convenient to use the actual constant from closure from here, and since it can't ever change, I don't think it's worth the trouble). |
wenbozhu
approved these changes
Nov 17, 2017
|
Please add a note to the changelog as a part of this PR. |
|
Agh! Good call, but I already pushed the merge button. :-( I'll send another PR... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified that our Authorization header is sent via the the '$httpHeaders' URL parameter now, the OPTIONS network round-trip no longer occurs, and our authentication token is still correctly respected by the backend.