Skip to content

use caret range for tslib to reduce dep fragmentation in user project #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2020
Merged

use caret range for tslib to reduce dep fragmentation in user project #3203

merged 1 commit into from
Jun 10, 2020

Conversation

Feiyang1
Copy link
Member

Fixes #3031

hiranya911
hiranya911 approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (1e3721c) and head commit (645585d).

Test Logs

@Feiyang1 Feiyang1 merged commit b9796f5 into master Jun 10, 2020
@Feiyang1 Feiyang1 deleted the fei-caret-dep branch June 10, 2020 18:57
@Feiyang1 Feiyang1 mentioned this pull request Jun 30, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

@alikn alikn Awaiting requested review from alikn

@andirayo andirayo Awaiting requested review from andirayo

@davideast davideast Awaiting requested review from davideast

@erikeldridge erikeldridge Awaiting requested review from erikeldridge

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

@jsdt jsdt Awaiting requested review from jsdt

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

@zwu52 zwu52 Awaiting requested review from zwu52

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firebase packages cause many duplicate tslib copies
3 participants
@Feiyang1 @google-oss-bot @hiranya911