Skip to content

upgrade grpc-js #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020
Merged

upgrade grpc-js #3202

merged 1 commit into from
Jun 10, 2020

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Jun 10, 2020

Fixes #3196

Changed it to ^1.0.0. @schmidt-sebastian Are you comfortable with the caret range? Does grpc-js follow semver?

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (1e3721c) and head commit (b9db2a3).

Test Logs

@schmidt-sebastian
Copy link
Contributor

schmidt-sebastian commented Jun 10, 2020

Looks like GitHub ate my comment again:

@Feiyang1
Copy link
Member Author

Feiyang1 commented Jun 10, 2020

If that works, we can probably pin grpc-js to a specific version in our repo to match the existing pattern in our SDk.

I actually think we should stop pinning to a specific version for external dependencies (non-@firebase dependencies), because otherwise it leads to package fragmentation problem seen in #3196 and #3031

Though we will lose some control on our dependencies, but if they follow semver, we will probably be fine.

So if you are comfortable with ^ range, I think we should use it.

@Feiyang1 Feiyang1 merged commit 53c0476 into master Jun 10, 2020
@Feiyang1 Feiyang1 deleted the fei-firestore-grpc branch June 10, 2020 23:34
@firebase firebase locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emulator Firestore: Channel credentials must be a ChannelCredentials object
3 participants