Add Firestore ReactNative build #3198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds work out of the box in RN since it relies on js-base64 for base64 encoding.
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
Feiyang1
suggested changes
Jun 11, 2020
| export function registerFirestore(instance: FirebaseNamespace): void { | ||
| configureForFirebase( | ||
| instance, | ||
| (app, auth) => new Firestore(app, auth, new IndexedDbComponentProvider()) |
There was a problem hiding this comment.
RN doesn't support indexeddb, so we should use MemoryComponentProvider here. Probably just remove this file, and point react-native in the root package.json to the memory build.
There was a problem hiding this comment.
We have some users that are using our IndexedDb Shim support. I am not sure if we should break them in this PR. FWIW, our main Node build also ships with IndexedDb support.
Feiyang1
approved these changes
Jun 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds work out of the box in RN since it relies on js-base64 for base64 encoding.
Fixes #2667