Provide document path context for input validation errors. #3189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs |
schmidt-sebastian
approved these changes
Jun 9, 2020
| @@ -107,11 +107,12 @@ export class ArrayUnionFieldValueImpl extends SerializableFieldValue { | |||
|
|
|||
| _toFieldTransform(context: ParseContext): FieldTransform { | |||
| // Although array transforms are used with writes, the actual elements | |||
| // being uniomed or removed are not considered writes since they cannot | |||
| // being unioned or removed are not considered writes since they cannot | |||
| // contain any FieldValue sentinels, etc. | |||
| const parseContext = new ParseContext( | |||
There was a problem hiding this comment.
It might be time to add a helper method to ParseContext (or a tree-shakeable function in this file) that simplifies the creation of an argument parser. If arrayElement remains configurable, this code would replace line 112-122, 145-155 and 173-181.
Optional.
There was a problem hiding this comment.
I pulled out createSentinelChildContext. LMK if this is what you had in mind.
| description += ' (found'; | ||
|
|
||
| if (hasPath) { | ||
| description += ` in field ${path!.toString()}`; |
There was a problem hiding this comment.
Nit: ${path!.toString()} is the same as ${path} (here and below).
schmidt-sebastian
approved these changes
Jun 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially addresses #3169.