Skip to content

Run integration/firestore tests for Firestore code changes #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented May 28, 2020

@thebrianchen noticed that one of our integration tests that only runs as part of integration/firestore broke. It looks like this was possible because we did not run those tests as part of Firestore changes.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 28, 2020

Binary Size Report

Affected SDKs

No changes between base commit (ec1471c) and head commit (ef43548).

Test Logs

@schmidt-sebastian
Copy link
Contributor Author

Tested with a change in the firestore package:

Running tests in:
integration/browserify (always runs)
integration/firebase-typings (always runs)
integration/typescript (always runs)
integration/webpack (always runs)
integration/firestore (depends on modified files)
packages/firestore (contains modified files)
packages/firebase (depends on modified files)

@schmidt-sebastian schmidt-sebastian merged commit 0d6f14e into master May 28, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixrunchanged branch May 28, 2020 19:31
@firebase firebase locked and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants