Skip to content

Allow shared usage of Transaction #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

This PR:

  • Removes the need to round-trip through RemoteStore to create a Transaction.
  • Removes the SortedMap dependency in Transaction to reduce code size in the Lite SDK.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (230cd48) Head (7541784) Diff
    browser 251 kB 251 kB +61 B (+0.0%)
    esm2017 195 kB 195 kB +69 B (+0.0%)
    main 493 kB 494 kB +123 B (+0.0%)
    module 249 kB 249 kB +61 B (+0.0%)
  • @firebase/firestore/memory

    Type Base (230cd48) Head (7541784) Diff
    browser 192 kB 192 kB +52 B (+0.0%)
    esm2017 149 kB 149 kB +60 B (+0.0%)
    main 369 kB 370 kB +89 B (+0.0%)
    module 190 kB 190 kB +52 B (+0.0%)
  • firebase

    Type Base (230cd48) Head (7541784) Diff
    firebase-firestore.js 290 kB 290 kB +63 B (+0.0%)
    firebase-firestore.memory.js 232 kB 232 kB +54 B (+0.0%)
    firebase.js 823 kB 823 kB +63 B (+0.0%)

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit 24c1ee9 into master May 27, 2020
@firebase firebase locked and limited conversation to collaborators Jun 27, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/apispilt3 branch July 9, 2020 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants