Address potential IndexedDB failure in synchronizeQueryViewsAndRaiseSnapshots

[schmidt-sebastian]

This removes a releaseQuery call from Multi-Tab synchronization. The idea of this code path in synchronizeQueryViewsAndRaiseSnapshots is that it releases and re-allocates a query if a new primary already has a local query view but needs to make sure that it matches the data in IndexedDB before starting a Listen.

We should not need to call releaseTarget here, since it overwrites the target data with potentially stale state. Instead, we just load the latest state via allocateTarget which has the ability to load a target from disk or from memory. I added a check to also update the in-memory data when it is stale, but I wasn't able to find any difference for this using a spec tests I hacked together (not committed).

Addresses #2755

[google-oss-bot]

Binary Size Report

Affected SDKs

• @firebase/firestore

  Type	Base (230cd48)	Head (a76b1b5)	Diff
  browser	251 kB	251 kB	-20 B (-0.0%)
  esm2017	195 kB	195 kB	+11 B (+0.0%)
  main	493 kB	493 kB	+38 B (+0.0%)
  module	249 kB	249 kB	-20 B (-0.0%)

• @firebase/firestore/memory

  Type	Base (230cd48)	Head (a76b1b5)	Diff
  browser	192 kB	192 kB	+25 B (+0.0%)
  esm2017	149 kB	149 kB	+34 B (+0.0%)
  main	369 kB	370 kB	+112 B (+0.0%)
  module	190 kB	190 kB	+25 B (+0.0%)

• firebase

  Type	Base (230cd48)	Head (a76b1b5)	Diff
  firebase-firestore.js	290 kB	290 kB	-20 B (-0.0%)
  firebase-firestore.memory.js	232 kB	232 kB	+25 B (+0.0%)
  firebase.js	823 kB	823 kB	-20 B (-0.0%)

Test Logs

• Base (230cd489): https://github.com/firebase/firebase-js-sdk/actions/runs/116206852
• Head (a76b1b5c): https://github.com/firebase/firebase-js-sdk/actions/runs/116530821

[wilhuff]

LGTM