Skip to content

IndexedDB recovery for handleUserChange #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2020
Merged

IndexedDB recovery for handleUserChange #3087

merged 1 commit into from
May 19, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Adresses #2755

@schmidt-sebastian schmidt-sebastian requested a review from wilhuff May 19, 2020 03:46
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (1325b58) Head (7737f6e) Diff
    browser 251 kB 251 kB -9 B (-0.0%)
    esm2017 194 kB 194 kB -10 B (-0.0%)
    module 248 kB 248 kB -9 B (-0.0%)

  • @firebase/firestore/memory

    Type Base (1325b58) Head (7737f6e) Diff
    browser 191 kB 191 kB -9 B (-0.0%)
    esm2017 149 kB 148 kB -10 B (-0.0%)
    module 189 kB 189 kB -9 B (-0.0%)

  • firebase

    Type Base (1325b58) Head (7737f6e) Diff
    firebase-firestore.js 289 kB 289 kB -9 B (-0.0%)
    firebase-firestore.memory.js 231 kB 231 kB -9 B (-0.0%)
    firebase.js 823 kB 823 kB -9 B (-0.0%)

Test Logs

wilhuff
wilhuff approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff May 19, 2020
@schmidt-sebastian schmidt-sebastian merged commit 1dc534a into master May 19, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/handleuserchange branch May 19, 2020 23:57
schmidt-sebastian added a commit that referenced this pull request Jun 9, 2020
@schmidt-sebastian
Revert: IndexedDB recovery for handleUserChange
f8d82bf 
Reverts #3087
Fixes #3179
@schmidt-sebastian schmidt-sebastian mentioned this pull request Jun 9, 2020
Closed
schmidt-sebastian added a commit that referenced this pull request Jun 9, 2020
@schmidt-sebastian
Revert: IndexedDB recovery for handleUserChange
16e4be0 
Reverts #3087
Fixes #3179
schmidt-sebastian added a commit that referenced this pull request Jun 9, 2020
@schmidt-sebastian
Revert: IndexedDB recovery for handleUserChange
caebb4b 
Reverts #3087
Fixes #3179
@firebase firebase locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wilhuff