Skip to content

Further refactoring of auth types. Add public exports to src/index.ts #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2020
Merged

Further refactoring of auth types. Add public exports to src/index.ts #3078

merged 3 commits into from
May 19, 2020

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented May 15, 2020

No description provided.

avolkovi
avolkovi approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@avolkovi avolkovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@scottcrossen scottcrossen removed their assignment May 18, 2020
@avolkovi avolkovi removed their assignment May 18, 2020
Feiyang1
Feiyang1 approved these changes May 19, 2020
View reviewed changes
packages-exp/auth-exp/src/core/auth/auth_impl.test.ts Outdated
@@ -271,18 +274,20 @@ describe('core/auth/initializeAuth', () => {

describe('persistence manager creation', () => {
let createManagerStub: sinon.SinonSpy;
// const inMemory = inMemoryPersistence as Persistence;
// const browserLocal = browserL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they supposed to be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops removed

@Feiyang1 Feiyang1 assigned sam-gc and unassigned Feiyang1 May 19, 2020
@sam-gc sam-gc force-pushed the samgho/better-types-2 branch from 9bf0d6d to 372bde8 Compare May 19, 2020 17:07
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 19, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (12e7465) Head (9658f2b) Diff
    esm2017 194 kB 194 kB -222 B (-0.1%)

  • @firebase/firestore/memory

    Type Base (12e7465) Head (9658f2b) Diff
    esm2017 149 kB 148 kB -190 B (-0.1%)

  • firebase

    Click to show 13 binary size changes.
    Type Base (12e7465) Head (9658f2b) Diff
    firebase-analytics.js 26.5 kB 26.5 kB -3 B (-0.0%)
    firebase-auth.js 173 kB 173 kB -226 B (-0.1%)
    firebase-database.js 187 kB 186 kB -494 B (-0.3%)
    firebase-firestore.js 289 kB 288 kB -802 B (-0.3%)
    firebase-firestore.memory.js 231 kB 230 kB -628 B (-0.3%)
    firebase-functions.js 9.60 kB 9.60 kB +1 B (+0.0%)
    firebase-installations.js 19.2 kB 19.2 kB -2 B (-0.0%)
    firebase-performance-standalone.es2017.js 72.7 kB 72.7 kB -13 B (-0.0%)
    firebase-performance-standalone.js 48.1 kB 47.9 kB -191 B (-0.4%)
    firebase-performance.js 38.5 kB 38.3 kB -203 B (-0.5%)
    firebase-remote-config.js 36.9 kB 36.9 kB -2 B (-0.0%)
    firebase-storage.js 40.9 kB 40.8 kB -65 B (-0.2%)
    firebase.js 823 kB 821 kB -1.70 kB (-0.2%)

Test Logs

@sam-gc sam-gc merged commit b278cea into auth-next May 19, 2020
@sam-gc sam-gc deleted the samgho/better-types-2 branch May 19, 2020 17:41
@firebase firebase locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi avolkovi approved these changes

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@scottcrossen scottcrossen scottcrossen approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

Assignees

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sam-gc @google-oss-bot @avolkovi @Feiyang1 @scottcrossen