Skip to content

Update internal types to work with external types #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 15, 2020
Merged

Update internal types to work with external types #3075

merged 5 commits into from
May 15, 2020

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented May 15, 2020

No description provided.

avolkovi
avolkovi approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@avolkovi avolkovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 so fresh and so clean

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 15, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (12bfc51) and head commit (0c117e6).

Test Logs

@sam-gc sam-gc merged commit 4d26e0d into auth-next May 15, 2020
sam-gc added a commit that referenced this pull request May 19, 2020
@sam-gc
Update internal types to work with external types (#3075)
12e7465 
* Update internal types to work with external types

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: License Headers

* PR feedback

* [AUTOMATED]: Prettier Code Styling
@firebase firebase locked and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi avolkovi approved these changes

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@scottcrossen scottcrossen Awaiting requested review from scottcrossen

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

Assignees

@avolkovi avolkovi

@Feiyang1 Feiyang1

@scottcrossen scottcrossen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sam-gc @google-oss-bot @avolkovi @Feiyang1 @scottcrossen