Add bundle.proto d.ts and introduce IDB object stores for bundles. #3073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs |
schmidt-sebastian
approved these changes
May 18, 2020
| option objc_class_prefix = "FSTPB"; | ||
| option php_namespace = "Firestore\\Proto"; | ||
|
|
||
| // Encodes a query saved in the bundle. |
There was a problem hiding this comment.
Nit: s/Encodes/Describes
Optional.
| // `BundleElement`. | ||
| // Only one `BundleMetadata` is expected, and it should be the first element. | ||
| // The named queries follow after `metadata`. Every `document_metadata` is | ||
| // immediately followed by a `document`. |
There was a problem hiding this comment.
The last part is not true anymore, is it? We skip document data for non-existing documents.
wu-hui
commented
May 19, 2020
| option objc_class_prefix = "FSTPB"; | ||
| option php_namespace = "Firestore\\Proto"; | ||
|
|
||
| // Encodes a query saved in the bundle. |
| // `BundleElement`. | ||
| // Only one `BundleMetadata` is expected, and it should be the first element. | ||
| // The named queries follow after `metadata`. Every `document_metadata` is | ||
| // immediately followed by a `document`. |
wu-hui
added a commit
that referenced
this pull request
May 21, 2020
…3073) * Manual copy proto and create bundle_proto.d.ts * IndexedDb schema change to introduce bundle object stores. * Renaming interfaces without leading I * Reordering imports * Address comments * Add totalBytes and totalDocuments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.