Skip to content

Fix Firestore build #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2020
Merged

Fix Firestore build #3066

merged 1 commit into from
May 14, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented May 14, 2020 •
edited
Loading

This is already part of #3038, but it looks like it broke CI for everyone so I pulled in out into a separate PR.

This broke because #3052 and #3020 were both passing CI on their own but not combined.

@schmidt-sebastian schmidt-sebastian requested a review from wilhuff May 14, 2020 19:12
wilhuff
wilhuff approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/firestore/test/unit/local/indexeddb_persistence.test.ts
@@ -1144,7 +1144,7 @@ describe('IndexedDb: allowTabSynchronization', () => {
'clientA',
/* multiClient= */ false,
async db => {
db.injectFailures = true;
db.injectFailures = { updateClientMetadataAndTryBecomePrimary: true };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning on making the other clients have the same transaction names? (Obviously they won't have the multitab related transactions, but how will this failure mechanism work anywhere else?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I am also planning to clean up our names before this happens.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (0131e1f) Head (498cbe8) Diff
    esm2017 ? 8.68 kB ? (?)
    main ? 9.69 kB ? (?)
    module ? 9.37 kB ? (?)

  • @firebase/app

    Type Base (0131e1f) Head (498cbe8) Diff
    browser ? 11.1 kB ? (?)
    esm2017 ? 9.46 kB ? (?)
    lite ? 9.10 kB ? (?)
    lite-esm2017 ? 7.75 kB ? (?)
    main ? 10.1 kB ? (?)
    module ? 11.0 kB ? (?)
    react-native ? 9.86 kB ? (?)

  • @firebase/auth

    Type Base (0131e1f) Head (498cbe8) Diff
    main ? 177 kB ? (?)
    module ? 177 kB ? (?)

  • @firebase/component

    Type Base (0131e1f) Head (498cbe8) Diff
    browser ? 5.16 kB ? (?)
    esm2017 ? 3.90 kB ? (?)
    main ? 5.16 kB ? (?)
    module ? 5.05 kB ? (?)

  • @firebase/database

    Type Base (0131e1f) Head (498cbe8) Diff
    browser ? 268 kB ? (?)
    esm2017 ? 235 kB ? (?)
    main ? 269 kB ? (?)
    module ? 266 kB ? (?)

  • @firebase/firestore

    Type Base (0131e1f) Head (498cbe8) Diff
    browser ? 250 kB ? (?)
    esm2017 ? 194 kB ? (?)
    main ? 491 kB ? (?)
    module ? 248 kB ? (?)

  • @firebase/firestore/memory

    Type Base (0131e1f) Head (498cbe8) Diff
    browser ? 190 kB ? (?)
    esm2017 ? 148 kB ? (?)
    main ? 367 kB ? (?)
    module ? 188 kB ? (?)

  • @firebase/functions

    Type Base (0131e1f) Head (498cbe8) Diff
    browser ? 9.17 kB ? (?)
    esm2017 ? 7.01 kB ? (?)
    main ? 9.21 kB ? (?)
    module ? 8.99 kB ? (?)

  • @firebase/installations

    Type Base (0131e1f) Head (498cbe8) Diff
    esm2017 ? 16.5 kB ? (?)
    main ? 22.0 kB ? (?)
    module ? 21.5 kB ? (?)

  • @firebase/logger

    Type Base (0131e1f) Head (498cbe8) Diff
    esm2017 ? 3.22 kB ? (?)
    main ? 5.09 kB ? (?)
    module ? 4.78 kB ? (?)

  • @firebase/messaging

    Type Base (0131e1f) Head (498cbe8) Diff
    esm2017 ? 23.2 kB ? (?)
    main ? 31.3 kB ? (?)
    module ? 30.9 kB ? (?)

  • @firebase/performance

    Type Base (0131e1f) Head (498cbe8) Diff
    browser ? 28.1 kB ? (?)
    esm2017 ? 26.1 kB ? (?)
    main ? 28.1 kB ? (?)
    module ? 27.9 kB ? (?)

  • @firebase/polyfill

    Type Base (0131e1f) Head (498cbe8) Diff
    main ? 733 B ? (?)
    module ? 666 B ? (?)

  • @firebase/remote-config

    Type Base (0131e1f) Head (498cbe8) Diff
    browser ? 23.1 kB ? (?)
    esm2017 ? 17.7 kB ? (?)
    main ? 23.1 kB ? (?)
    module ? 22.7 kB ? (?)

  • @firebase/storage

    Type Base (0131e1f) Head (498cbe8) Diff
    esm2017 ? 56.4 kB ? (?)
    main ? 62.7 kB ? (?)
    module ? 62.5 kB ? (?)

  • @firebase/testing

    Type Base (0131e1f) Head (498cbe8) Diff
    main ? 6.67 kB ? (?)

  • @firebase/util

    Type Base (0131e1f) Head (498cbe8) Diff
    browser ? 19.5 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 19.5 kB ? (?)
    module ? 18.6 kB ? (?)

  • @firebase/webchannel-wrapper

    Type Base (0131e1f) Head (498cbe8) Diff
    esm2017 ? 37.7 kB ? (?)
    main ? 38.8 kB ? (?)
    module ? 38.4 kB ? (?)

  • firebase

    Click to show 15 binary size changes.
    Type Base (0131e1f) Head (498cbe8) Diff
    firebase-analytics.js ? 26.5 kB ? (?)
    firebase-app.js ? 19.9 kB ? (?)
    firebase-auth.js ? 173 kB ? (?)
    firebase-database.js ? 187 kB ? (?)
    firebase-firestore.js ? 288 kB ? (?)
    firebase-firestore.memory.js ? 230 kB ? (?)
    firebase-functions.js ? 9.60 kB ? (?)
    firebase-installations.js ? 19.2 kB ? (?)
    firebase-messaging.js ? 39.1 kB ? (?)
    firebase-performance-standalone.es2017.js ? 72.7 kB ? (?)
    firebase-performance-standalone.js ? 48.1 kB ? (?)
    firebase-performance.js ? 38.5 kB ? (?)
    firebase-remote-config.js ? 36.9 kB ? (?)
    firebase-storage.js ? 40.9 kB ? (?)
    firebase.js ? 822 kB ? (?)

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit ab2e73d into master May 14, 2020
@firebase firebase locked and limited conversation to collaborators Jun 14, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixbuild branch July 9, 2020 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@Feiyang1 Feiyang1

@wilhuff wilhuff

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @google-oss-bot @wilhuff @Feiyang1