Skip to content

Mass replace Google Inc with Google LLC #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2020
Merged

Mass replace Google Inc with Google LLC #3054

merged 3 commits into from
May 14, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Fix random stray file changes in the JS SDK.

yuchenshi
yuchenshi approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@yuchenshi yuchenshi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for whatever files I have OWNERS on. And please unsubscribe me (or re-subscribe me three times) from this PR.

But more seriously, global approvers, PTAL.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 13, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase

    Type Base (54c7872) Head (8697d2c) Diff
    firebase-performance-standalone.es2017.js 72.7 kB 72.7 kB -52 B (-0.1%)

Test Logs

@Feiyang1
Copy link
Member

I will fix the test in another PR.

@Feiyang1
Copy link
Member

#3056

zwu52
zwu52 approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@zwu52 zwu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the 1 time change

@Feiyang1 Feiyang1 merged commit 0131e1f into master May 14, 2020
@Feiyang1 Feiyang1 deleted the mrschmidt/fixllc branch May 14, 2020 18:44
@firebase firebase locked and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@scottcrossen scottcrossen scottcrossen approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@zwu52 zwu52 zwu52 approved these changes

@alikn alikn Awaiting requested review from alikn

@andirayo andirayo Awaiting requested review from andirayo

@avolkovi avolkovi Awaiting requested review from avolkovi

@bojeil-google bojeil-google Awaiting requested review from bojeil-google

@davideast davideast Awaiting requested review from davideast

@erikeldridge erikeldridge Awaiting requested review from erikeldridge

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

@jsdt jsdt Awaiting requested review from jsdt

@sam-gc sam-gc Awaiting requested review from sam-gc

@wti806 wti806 Awaiting requested review from wti806

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@Feiyang1 Feiyang1

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@schmidt-sebastian @google-oss-bot @Feiyang1 @scottcrossen @yuchenshi @zwu52 @hsubox76