Skip to content

Upgrade closure-builder to fix #183. #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2017
Merged

Conversation

mikelehen
Copy link
Contributor

Josh, this should fix #183. Thoughts about including it in this week's release?

Also, I don't really understand why extra stuff in yarn.lock changed. Let me know if you think it's problematic.

@jshcrowthe
Copy link
Contributor

Sounds good! I'll stage the release for testing after merging this.

The yarn.lock is updated as it fixed the version of closure builder to the specific patch. It being updated here is to be expected.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@mikelehen
Copy link
Contributor Author

Yeah, I expected closure-builder to change in yarn.lock, but there were several other diffs too. Perhaps those were dependencies of closure-builder or something though. I'm not sure.

@mikelehen mikelehen merged commit 43785a4 into master Nov 8, 2017
@mikelehen mikelehen deleted the mikelehen-update-closure branch November 8, 2017 20:25
@firebase firebase locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Image is not defined" error when using Cloud Firestore from React Native app
4 participants