Skip to content

Point to the internal typing file in app-exp's package.json #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2020
Merged

Point to the internal typing file in app-exp's package.json #3030

merged 3 commits into from
May 6, 2020

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented May 6, 2020 •
edited
Loading

Additionally removed api report step from prepush as it often creates unwanted changes, so I have made it part of the build step instead.

@Feiyang1 Feiyang1 force-pushed the fei-fix-exp-type branch from bee613f to 98d45d4 Compare May 6, 2020 22:17
@Feiyang1 Feiyang1 force-pushed the fei-fix-exp-type branch from 98d45d4 to acd4cf1 Compare May 6, 2020 22:20
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 6, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (575b3fe) and head commit (fef2610).

Test Logs

@hsubox76 hsubox76 mentioned this pull request May 6, 2020
Merged
@Feiyang1 Feiyang1 merged commit 8143c83 into master May 6, 2020
@Feiyang1 Feiyang1 deleted the fei-fix-exp-type branch May 6, 2020 23:16
@firebase firebase locked and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feiyang1 @google-oss-bot @hsubox76