Skip to content

Remove dependency on valueCompare from Document #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2020
Merged

Remove dependency on valueCompare from Document #3024

merged 2 commits into from
May 6, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Changes for consumed API for deleteDocument:

Screen Shot 2020-05-05 at 1 19 33 PM

@schmidt-sebastian schmidt-sebastian requested a review from dconeybe May 5, 2020 20:24
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/doccomparator branch from 5e66494 to e3b0513 Compare May 5, 2020 20:28
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 5, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (76ba2ea) Head (81fbb08) Diff
    browser 248 kB 248 kB -35 B (-0.0%)
    esm2017 193 kB 193 kB -23 B (-0.0%)
    main 488 kB 488 kB +32 B (+0.0%)
    module 246 kB 246 kB -35 B (-0.0%)

  • @firebase/firestore/memory

    Type Base (76ba2ea) Head (81fbb08) Diff
    browser 188 kB 188 kB -35 B (-0.0%)
    esm2017 148 kB 148 kB -23 B (-0.0%)
    main 365 kB 365 kB +32 B (+0.0%)
    module 187 kB 187 kB -35 B (-0.0%)

  • firebase

    Type Base (76ba2ea) Head (81fbb08) Diff
    firebase-firestore.js 287 kB 287 kB -35 B (-0.0%)
    firebase-firestore.memory.js 228 kB 228 kB -35 B (-0.0%)
    firebase.js 820 kB 820 kB -35 B (-0.0%)

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit 575b3fe into master May 6, 2020
@schmidt-sebastian schmidt-sebastian mentioned this pull request May 7, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Jun 6, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/doccomparator branch November 9, 2020 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @dconeybe