Ignore IndexedDB failures during garbage collection #3015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale is that they the LRU task will retry its run when it is invoked next. There are no tests since the GC scheduling code is not tested right now. Let me know if you would like me to add tests. Note that there is a behavior change: If the primary lease is lost, the GC run is rescheduled. It will however get stoped in https://github.com/firebase/firebase-js-sdk/blob/5a60243bf264967819fc5c3897892084c5eb4d43/packages/firestore/src/core/component_provider.ts#L203
schmidt-sebastian
force-pushed
the
mrschmidt/dontcrashonlru
branch
from
313e0ac to
ab16cf5
Compare
schmidt-sebastian
changed the title
Binary Size ReportAffected SDKs
Test Logs |
wilhuff
approved these changes
May 5, 2020
| await localStore.collectGarbage(this.garbageCollector); | ||
| } catch (e) { | ||
| if (e.name === 'IndexedDbTransactionError') { | ||
| logDebug(LOG_TAG, 'Ignoring IndexedDB error during LRU: ', e); |
There was a problem hiding this comment.
"LRU" is not a great descriptor of what's going on here. How about "garbage collection"?
Also update the PR description.
schmidt-sebastian
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale is that they the LRU task will retry its run when it is invoked next.
There are no tests since the GC scheduling code is not tested right now. Let me know if you would like me to add tests.
Note that there is a behavior change: If the primary lease is lost, the GC run is rescheduled. It will however get stoped in
firebase-js-sdk/packages/firestore/src/core/component_provider.ts
Line 203 in 5a60243
Addresses #2755