Drop SortedSet from FieldMask #2999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs |
schmidt-sebastian
force-pushed
the
mrschmidt/arraybackedfieldvalues
branch
from
2fa771a to
60bd5a3
Compare
dconeybe
approved these changes
Apr 30, 2020
| fields.sort(FieldPath.comparator); | ||
| debugAssert( | ||
| !fields.some((v, i) => i !== 0 && v.isEqual(fields[i - 1])), | ||
| 'FieldMask contains fields that are not unique' |
There was a problem hiding this comment.
It may be helpful to include the name of the repeated field in the message. Consider adding this.
There was a problem hiding this comment.
I couldn't think of a clean way to do this, so I added an ugly way. Done.
There was a problem hiding this comment.
There are three code paths that generated FieldMasks:
- A field mask is provided explicitly via
mergeFields. In this case, we turn an O(n log n) operation into O(n2). - A field mask update is provided in an update vargargs call. In this case, we also turn an O(n log n) operation into O(n2).
- A field mask is generated from an ObjectValue or from a DocumentData object. In this case, the creation of the field mask is now O(n), but with the additional sort it becomes O(n log n), which is the same as before.
I think we are ok here since cases 1 and 2 should not deal with huge field masks.
| fields.sort(FieldPath.comparator); | ||
| debugAssert( | ||
| !fields.some((v, i) => i !== 0 && v.isEqual(fields[i - 1])), | ||
| 'FieldMask contains fields that are not unique' |
There was a problem hiding this comment.
I couldn't think of a clean way to do this, so I added an ugly way. Done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to not use SortedSet in FieldMask since the Rest Wrapper API ideally does not pull in our custom Red Black Tree. FieldMasks are used in any update/set(merge:true) call.
Right now, I have a debug assert that makes sure FieldMasks only contain unique fields. This means we have to validate this as we turn user data into FieldMasks. We could also strip duplicated fields in the FieldMask constructor.