Skip to content

Add auth listener implementation, add user.reload() #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 23, 2020
Merged

Add auth listener implementation, add user.reload() #2961

merged 11 commits into from
Apr 23, 2020

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Apr 21, 2020

No description provided.

@sam-gc sam-gc requested review from avolkovi and scottcrossen April 21, 2020 20:22
@avolkovi avolkovi changed the base branch from auth-next to samgho/auth-next-user-impl April 21, 2020 20:28
@avolkovi avolkovi changed the base branch from samgho/auth-next-user-impl to samgho/auth-object April 21, 2020 20:29
avolkovi
avolkovi reviewed Apr 21, 2020
View reviewed changes
packages-exp/auth-exp/src/core/auth/auth_impl.test.ts
auth.currentUser = user;
auth._isInitialized = true;
auth.onAuthStateChanged(user => {
expect(user).to.eq(user);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use expect(callback).to.have.been.calledWith() instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, maybe I misunderstood, it looks like you used calledWith() down below, but not in these test cases

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 21, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (3bb6376) and head commit (b010078).

Test Logs

@sam-gc sam-gc force-pushed the samgho/auth-subscribers branch from 14488c0 to c263a72 Compare April 22, 2020 16:10
@sam-gc sam-gc changed the base branch from samgho/auth-object to auth-next April 22, 2020 16:11
@sam-gc sam-gc marked this pull request as ready for review April 22, 2020 16:14
@sam-gc sam-gc requested a review from avolkovi April 22, 2020 16:14
@sam-gc sam-gc requested a review from bojeil-google April 22, 2020 16:14
@sam-gc sam-gc force-pushed the samgho/auth-subscribers branch from 7f4ca92 to 977fd2b Compare April 22, 2020 22:04
@avolkovi avolkovi force-pushed the samgho/auth-subscribers branch from 977fd2b to 83f05ba Compare April 23, 2020 19:30
@sam-gc sam-gc force-pushed the samgho/auth-subscribers branch from 83f05ba to f12ebec Compare April 23, 2020 22:58
@sam-gc sam-gc merged commit 48c6624 into auth-next Apr 23, 2020
avolkovi pushed a commit that referenced this pull request Apr 24, 2020
@sam-gc @avolkovi
Add auth listener implementation, add user.reload() (#2961)
37a89ca
@avolkovi avolkovi deleted the samgho/auth-subscribers branch April 24, 2020 20:30
sam-gc added a commit that referenced this pull request May 19, 2020
@sam-gc
Add auth listener implementation, add user.reload() (#2961)
deab6e3
@firebase firebase locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi avolkovi approved these changes

@scottcrossen scottcrossen scottcrossen approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

@bojeil-google bojeil-google Awaiting requested review from bojeil-google

Assignees

@avolkovi avolkovi

@scottcrossen scottcrossen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-gc @google-oss-bot @avolkovi @scottcrossen