Skip to content

Added react native build target #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Added react native build target #2947

merged 1 commit into from
Apr 21, 2020

Conversation

scottcrossen
Copy link
Contributor

Adds react native target for dependency injection of package react-native (not @react-native-community/async-storage for consistency with old SDK) in compat layer.

Note that this build target wasn't added to auth-exp because the new package will need user specification on which package to use to setup.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (fc45b6c) and head commit (76058d7).

Test Logs

Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending what other folks say

@scottcrossen scottcrossen assigned Feiyang1 and unassigned avolkovi and sam-gc Apr 21, 2020
@scottcrossen scottcrossen merged commit a4e74fd into auth-next Apr 21, 2020
avolkovi pushed a commit that referenced this pull request Apr 22, 2020
@scottcrossen scottcrossen deleted the react-native-build branch April 23, 2020 05:32
avolkovi pushed a commit that referenced this pull request Apr 23, 2020
avolkovi pushed a commit that referenced this pull request Apr 24, 2020
sam-gc pushed a commit that referenced this pull request May 19, 2020
@firebase firebase locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants