Skip to content

Don't include GRPC in browser build #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2020
Merged

Don't include GRPC in browser build #2935

merged 4 commits into from
Apr 20, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This addresses an OOM in Saucelabs, since tries to make grpc-js work in IE11. We should not include any tests that depend on GRPC-JS

@schmidt-sebastian
Don't include in browser build
f60d60e 
This addresses an OOM in Saucelabs, since  tries to make grpc-js work in IE11. We should not include any tests that depend on GRPC-JS
@schmidt-sebastian
[AUTOMATED]: Prettier Code Styling
225b922
@schmidt-sebastian
[AUTOMATED]: License Headers
99316a0
schmidt-sebastian
schmidt-sebastian commented Apr 18, 2020
View reviewed changes
packages/firestore/test/unit/remote/serializer.helper.ts
* These tests are initialized in 'serializer.browser.test.ts' and
* 'serializer.node.test.ts'.
*/
export function serializerTest(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this file is the same as serializer.test.ts, but wrapped in this function. I also pulled out verifyProtobufJsRoundTrip

@schmidt-sebastian schmidt-sebastian changed the title Don't include in browser build Don't include GRPC in browser build Apr 18, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (537350e) and head commit (59eca76).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 18, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (537350e) and head commit (d1d721a).

Test Logs

hsubox76
hsubox76 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely seems to fix the unit tests! I will look into another approach for integration (maybe use integration/firestore instead). I think the failing check on this PR is just flaky.

@schmidt-sebastian schmidt-sebastian merged commit 7396d48 into master Apr 20, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/nodetests branch April 20, 2020 19:40
@firebase firebase locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees

@hsubox76 hsubox76

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @hsubox76