Add the umbrella firebase package for modular packages #2927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
reviewed
Apr 17, 2020
| @@ -0,0 +1,35 @@ | |||
| /** | |||
There was a problem hiding this comment.
Is this the CDN build? Is it not going to include polyfills anymore? Should we still registerVersion as 'cdn' to track when this build is used?
There was a problem hiding this comment.
Yes, it's the firebase.js file. I don't think we need to include polyfills for several reasons:
- This file is intended for development and most people would use newer browsers that don't need polyfills.
- It discourages people to use it in production because it won't work in "all" browsers out of box.
- People can add polyfills themselves if needed. And I want us to get out of the business of deciding what polyfills to include and maintaining them forever.
Yup, good idea that we should keep tracking its usage. Will update.
There was a problem hiding this comment.
Added packages-exp/firebase-exp/app/index.cdn.ts. PTAL.
hsubox76
approved these changes
Apr 17, 2020
hsubox76
reviewed
Apr 17, 2020
| @@ -46,7 +46,7 @@ function visitNodeAndChildren(node, context) { | |||
|
|
|||
| function visitNode(node) { | |||
| let importPath; | |||
| if (ts.isImportDeclaration(node)) { | |||
| if (ts.isImportDeclaration(node) || ts.isExportDeclaration(node)) { | |||
| const importPathWithQuotes = node.moduleSpecifier.getText(); | |||
There was a problem hiding this comment.
Seems to be causing a build error, need to do a null check on moduleSpecifier?
hsubox76
requested changes
Apr 17, 2020
hsubox76
approved these changes
Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.