Add a persistence manager class #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sam-gc merged 26 commits into auth-next from samgho/persistence-manager

Apr 20, 2020

Contributor

sam-gc commented Apr 16, 2020

No description provided.

sam-gc added 12 commits

April 16, 2020 14:02


          Add persistence layer: index db, in memory, and browser{local, session}

f6d83b5


          [AUTOMATED]: Prettier Code Styling

efab6d0


          Add indexed_db isAvailable test

b561823


          [AUTOMATED]: Prettier Code Styling

67e46a9


          Add persistence layer: index db, in memory, and browser{local, session}

7cc84c1


          [AUTOMATED]: Prettier Code Styling

c9bbfe8


          [AUTOMATED]: License Headers

67446ea


          Add persistence manager class

afdce7e


          [AUTOMATED]: Prettier Code Styling

ef91d2b


          [AUTOMATED]: License Headers

0d8659d


          Formatting

a15679c


          Formatting

4254fac

sam-gc requested review from avolkovi and bojeil-google

April 16, 2020 21:11

sam-gc assigned avolkovi

sam-gc marked this pull request as ready for review

April 16, 2020 21:12

sam-gc requested review from Feiyang1, hiranya911 and hsubox76 as code owners

April 16, 2020 21:12

Contributor

google-oss-bot commented Apr 16, 2020 •

edited

Loading

Binary Size Report

Affected SDKs

No changes between base commit (bcccf36) and head commit (bba5db2).

Test Logs

Base (bcccf366): https://github.com/firebase/firebase-js-sdk/actions/runs/80171925
Head (bba5db27): https://github.com/firebase/firebase-js-sdk/actions/runs/81151456

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/persistence_user_manager.ts Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/persistence_user_manager.ts Outdated Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/persistence_user_manager.ts Outdated Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/persistence_user_manager.ts Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/user/token_manager.test.ts Outdated Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/user/token_manager.ts Outdated Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/user/user_impl.test.ts Outdated Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/user/user_impl.ts Outdated Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/persistence_user_manager.test.ts Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/persistence_user_manager.test.ts Outdated Show resolved Hide resolved


          [AUTOMATED]: Prettier Code Styling

ed0ff67

avolkovi approved these changes

View reviewed changes

sam-gc added 2 commits

April 16, 2020 16:21


          Add util/assert

a1cbef8


          [AUTOMATED]: Prettier Code Styling

f1cfec2

sam-gc commented

View reviewed changes

packages-exp/auth-exp/src/core/util/assert.ts Show resolved Hide resolved

sam-gc added 2 commits

April 17, 2020 10:02


          Update assertType to allow multiple types

eebc885


          [AUTOMATED]: Prettier Code Styling

1d93a6d

Feiyang1 reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/persistence_user_manager.ts Outdated

Comment on lines 24 to 28

+              export const AUTH_USER_KEY_NAME_ = 'authUser';
+              export const PERSISTENCE_KEY_NAME_ = 'persistence';
+              const PERSISTENCE_NAMESPACE_ = 'firebase';
+              export function persistenceKeyName_(

Member

Feiyang1 Apr 17, 2020 •

edited

Loading

I don't think we have an official rule on prefix _ vs suffix _ for internal functions/constants yet, but I'd like to establish the convention of using prefix _. @firebase/firestore and @firebase/app are already using prefix _ today and the documentation tool we are going to use will flag functions with @internal annotation without prefix _.
WDYT?

Contributor Author

sam-gc Apr 17, 2020

Sg, done

sam-gc added 5 commits

April 17, 2020 12:52


          UserImpl toPlainObject

a6338ec


          Move instantiation into persistence manager, add a toPlainObject as well

ede366c


          [AUTOMATED]: Prettier Code Styling

8ccb75e


          Move CONST_ to _CONST

1fce8ba


          [AUTOMATED]: Prettier Code Styling

df6c1d0

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/index.ts Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/indexed_db.ts Outdated Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/indexed_db.ts Outdated Show resolved Hide resolved

avolkovi reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/persistence_user_manager.ts Show resolved Hide resolved

avolkovi approved these changes

View reviewed changes

sam-gc added 2 commits

April 17, 2020 15:33


          PR feedback

cd255da


          [AUTOMATED]: Prettier Code Styling

ea70a8a

sam-gc requested a review from scottcrossen

April 17, 2020 22:39

Feiyang1 reviewed

View reviewed changes

packages-exp/auth-exp/src/core/persistence/persistence_user_manager.ts Outdated

+              export const _PERSISTENCE_KEY_NAME = 'persistence';
+              const _PERSISTENCE_NAMESPACE = 'firebase';
+              export function persistenceKeyName_(

Member

Feiyang1 Apr 17, 2020

nit: change to prefix _

Contributor Author

sam-gc Apr 17, 2020

woops done


          Addressing PR feedback

2749d1e

Feiyang1 approved these changes

View reviewed changes

sam-gc merged commit fc45b6c into auth-next

avolkovi pushed a commit that referenced this pull request


          Add a persistence manager class (#2925)

ca135bb

avolkovi pushed a commit that referenced this pull request


          Add a persistence manager class (#2925)

b442243

avolkovi pushed a commit that referenced this pull request


          Add a persistence manager class (#2925)

ad8ce0e

sam-gc added a commit that referenced this pull request


          Add a persistence manager class (#2925)

a3a7281

firebase locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

avolkovi avolkovi approved these changes

Feiyang1 Feiyang1 approved these changes

bojeil-google Awaiting requested review from bojeil-google

hiranya911 Awaiting requested review from hiranya911

hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

scottcrossen Awaiting requested review from scottcrossen

Labels

None yet