Add fetchSignInMethodsForEmail to auth-next #2924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avolkovi
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
sam-gc
approved these changes
Apr 16, 2020
| */ | ||
|
|
||
| export function getCurrentUrl(): string { | ||
| return window?.location?.href || self?.location?.href || ''; |
There was a problem hiding this comment.
Isn't self just a direct alias to window?
There was a problem hiding this comment.
apparently window doesn't exist in workers but self does, this should probably just use the self version though
There was a problem hiding this comment.
Feiyang1
approved these changes
Apr 17, 2020
avolkovi
added a commit
that referenced
this pull request
Apr 22, 2020
* Add fetchSignInMethodsForEmail to auth-next * [AUTOMATED]: Prettier Code Styling * PR Feedback * [AUTOMATED]: Prettier Code Styling
avolkovi
added a commit
that referenced
this pull request
Apr 23, 2020
* Add fetchSignInMethodsForEmail to auth-next * [AUTOMATED]: Prettier Code Styling * PR Feedback * [AUTOMATED]: Prettier Code Styling
avolkovi
added a commit
that referenced
this pull request
Apr 24, 2020
* Add fetchSignInMethodsForEmail to auth-next * [AUTOMATED]: Prettier Code Styling * PR Feedback * [AUTOMATED]: Prettier Code Styling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.