Add persistence layer: index db, in memory, and browser{local, session} #2908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avolkovi
reviewed
Apr 14, 2020
avolkovi
reviewed
Apr 14, 2020
| import { User } from '../../model/user'; | ||
| import { testUser } from '../../../test/mock_auth'; | ||
|
|
||
| describe('core/persistence/in_memory', () => { |
There was a problem hiding this comment.
should we standardize on how we name these?
There was a problem hiding this comment.
Sure, how would you like to standardize them? I don't really care which way we end up choosing
There was a problem hiding this comment.
me neither, is there a pattern that the other packages follow? @Feiyang1
avolkovi
reviewed
Apr 14, 2020
avolkovi
reviewed
Apr 14, 2020
| this.storage[key] = value; | ||
| } | ||
|
|
||
| async get<T extends PersistenceValue>(key: string): Promise<T | null> { |
There was a problem hiding this comment.
do you have a version of this one with instantiator?
avolkovi
reviewed
Apr 14, 2020
avolkovi
reviewed
Apr 14, 2020
avolkovi
approved these changes
Apr 14, 2020
avolkovi
pushed a commit
that referenced
this pull request
Apr 22, 2020
avolkovi
pushed a commit
that referenced
this pull request
Apr 23, 2020
avolkovi
pushed a commit
that referenced
this pull request
Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.