Skip to content

Prefix list results with correct bucket #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2020
Merged

Prefix list results with correct bucket #2905

merged 3 commits into from
Apr 15, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

We need to use the same bucket in the list response as in the list request.

Fixes https://b.corp.google.com/issues/152053124

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/storage

    Type Base (7f69b70) Head (330fbcf) Diff
    esm2017 56.6 kB 56.4 kB -222 B (-0.4%)
    main 62.9 kB 62.7 kB -220 B (-0.3%)
    module 62.7 kB 62.5 kB -220 B (-0.4%)

  • firebase

    Type Base (7f69b70) Head (330fbcf) Diff
    firebase-storage.js 41.0 kB 40.9 kB -117 B (-0.3%)
    firebase.js 828 kB 828 kB -117 B (-0.0%)

Test Logs

@schmidt-sebastian
Copy link
Contributor Author

@hsubox76 Do you mind approving this?

@schmidt-sebastian schmidt-sebastian merged commit 2119310 into master Apr 15, 2020
@firebase firebase locked and limited conversation to collaborators May 16, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/listall branch July 9, 2020 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fredzqm fredzqm fredzqm approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees

@fredzqm fredzqm

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @google-oss-bot @fredzqm @hsubox76