Fix Messaging test that fails in Firefox #2883

hsubox76 · 2020-04-08T03:05:06Z

A step towards fixing all cross-browser tests. This is the only failing test for Messaging.

google-oss-bot · 2020-04-08T03:14:10Z

Binary Size Report

SDK	Type	Base (`a789d74`)	Head (`d7b3a49`)	Diff
@firebase/firestore/memory	browser	209974.00	198105.00	-11869.00 (-5.65%)
	module	208377.00	196503.00	-11874.00 (-5.70%)
	esm2017	167439.00	155605.00	-11834.00 (-7.07%)
	main	374458.00	374451.00	-7.00 (-0.00%)
@firebase/firestore	browser	266685.00	252362.00	-14323.00 (-5.37%)
	module	264671.00	250342.00	-14329.00 (-5.41%)
	esm2017	213317.00	199040.00	-14277.00 (-6.69%)
	main	486146.00	486139.00	-7.00 (-0.00%)
@firebase/performance	browser	25158.00	28112.00	+2954.00 (+11.74%)
	module	24914.00	27862.00	+2948.00 (+11.83%)
	esm2017	23188.00	26090.00	+2902.00 (+12.52%)
	main	25158.00	28112.00	+2954.00 (+11.74%)
firebase	firebase.js	840365.00	827721.00	-12644.00 (-1.50%)
	firebase-firestore.memory.js	253080.00	241200.00	-11880.00 (-4.69%)
	firebase-performance-standalone.js	46427.00	48119.00	+1692.00 (+3.64%)
	firebase-performance.js	36778.00	38470.00	+1692.00 (+4.60%)
	firebase-firestore.js	308468.00	294131.00	-14337.00 (-4.65%)
	1 more entries not displayed here ...

Metric Unit: byte

packages/messaging/src/controllers/sw-controller.test.ts

hsubox76 added 2 commits April 7, 2020 20:03

Fix Saucelabs test for messaging

9ff44db

[AUTOMATED]: License Headers

8e4cba1

hsubox76 requested a review from Feiyang1 April 8, 2020 18:38

Feiyang1 reviewed Apr 9, 2020

View reviewed changes

packages/messaging/src/controllers/sw-controller.test.ts Outdated Show resolved Hide resolved

Feiyang1 approved these changes Apr 9, 2020

View reviewed changes

Add link regarding maxActions Firefox support

3186eba

hsubox76 merged commit 7fa3d03 into master Apr 9, 2020

firebase locked and limited conversation to collaborators May 10, 2020

hsubox76 deleted the ch-saucelabs branch June 18, 2020 21:09